a_sidorin requested changes to this revision. a_sidorin added a comment. This revision now requires changes to proceed.
Hello Stephen, These methods will be really useful. ================ Comment at: lib/Basic/SourceLocation.cpp:90 + B.print(OS, SM); + OS << ",\n "; + E.print(OS, SM); ---------------- I think we should print both locations on the same line, without adding a newline after the start SLoc. ================ Comment at: lib/Basic/SourceLocation.cpp:92 + E.print(OS, SM); + OS << "]\n"; +} ---------------- print() shouldn't add a newline, it is up to dump() methods. Repository: rC Clang https://reviews.llvm.org/D50662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
