sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
This part looks good (I think everything controversial got moved into the other patch). Thanks! ================ Comment at: clangd/Threading.cpp:75 + std::string ThreadName; + decltype(Action) ThreadFunc; + decltype(CleanupTask) Cleanup; ---------------- nit: maybe call these CallAction and CallCleanupTask or something to make the parallels completely explicit. Up to you Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50993 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
