sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:123
+ size_t Bytes = Index.estimateMemoryUsage();
+ for (const auto &Scheme : URISchemes) {
+ // std::string contains chars with sizeof(char) == 1.
----------------
ioeric wrote:
> I think the URI scheme names should be negligible.
yeah, just drop this I think.
================
Comment at: clang-tools-extra/clangd/index/Index.h:391
+ // FIXME(kbobyrev): Currently, this only returns the size of index itself
+ // excluding the size of actual symbol slab index refers to. It might be
+ // useful to return both.
----------------
it might be useful --> we should include both :-)
https://reviews.llvm.org/D51154
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
