hokein added inline comments.
================
Comment at: docs/clang-tidy/checks/abseil-no-internal-deps.rst:17
+
+ absl::strings_internal::foo();
+ class foo {
----------------
I think this line is also triggered the warning?
================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:8
+#include "absl/external-file.h"
+// CHECK: absl/external-file.h:1:23: warning: do not reference any 'internal'
namespaces; those implementation details are reserved to Abseil
[abseil-no-internal-deps]
+
----------------
Does the test get passed on the first run `RUN: %check_clang_tidy %s
abseil-no-internal-deps %t, -- -- -I %S/Inputs` of the test? It will suppress
clang-tidy warnings from the header, and the warning here should not appear.
https://reviews.llvm.org/D50542
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
