ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LG with a few small comments
================
Comment at: clangd/Protocol.cpp:635
+ if(const auto AsNumber = Params->getAsInteger())
+ return utostr(AsNumber.getValue());
+
----------------
Maybe use itostr?
================
Comment at: clangd/Protocol.cpp:641
+bool fromJSON(const json::Value &Params, CancelParams &CP) {
+ if(const auto Parsed = parseNumberOrString(Params.getAsObject()->get("id")))
{
+ CP.ID = *Parsed;
----------------
What is Params is not an object?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
