rsmith added a comment.

In https://reviews.llvm.org/D51240#1213179, @davidxl wrote:

> Can you split the patch into two? One for sample PGO and one for 
> instrumentation.


I've split the patch up thusly:

https://reviews.llvm.org/D51246 is the common infrastructure shared by sample 
PGO and instrumentation-based profiling.
https://reviews.llvm.org/D51247 is the core support for remapping profiling 
data for instrumentation-based profiling.
https://reviews.llvm.org/D51248 is the core support for remapping profiling 
data for sample-based profiling.
https://reviews.llvm.org/D51249 is plumbing the relevant flag through the pass 
manager, LTO, etc. I can try to split that up into instrumentation vs sample 
profiling too, but some parts of it are common between the two, so it's not 
straightforward.

The remaining changes are the plumbing in Clang to add the command-line flag 
and pass it into LLVM, which are essentially all common to both forms of 
profiling.


https://reviews.llvm.org/D51240



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D51240: A... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D512... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D512... David Li via Phabricator via cfe-commits
    • [PATCH] D512... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D512... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D512... David Li via Phabricator via cfe-commits
    • [PATCH] D512... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to