ioeric added inline comments.
================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:32 static llvm::cl::opt<bool> - UseDex("use-dex-index", ---------------- I think we should stick to the same option and just flip the default. Introducing yet another option (that is going to be removed) could be confusing. ================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:33 static llvm::cl::opt<bool> - UseDex("use-dex-index", - llvm::cl::desc("Use experimental Dex static index."), ---------------- Also add FIXME indicating that the option will be removed soon. https://reviews.llvm.org/D51352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits