[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: lib/Driver/ToolChains/HIP.cpp:255
+                         options::OPT_fvisibility_ms_compat)) {
+    CC1Args.push_back("-fvisibility");
+    CC1Args.push_back("hidden");
----------------
Nit: You could collapse multiple `push_back` calls into a single 
`append({...})`:
`CC1Args.append({"-fvisibility", "hidden"});`


https://reviews.llvm.org/D51434



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits