ioeric added inline comments.
================
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+ struct Base {
----------------
ilya-biryukov wrote:
> Was wondering if testing for crashes LG this way, or adding more assertions
> might make sense too
Hmm, I think this is okay, but I'd probably do some sanity check on the
results, just to make it look less odd ;)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51598
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
