benhamilton added inline comments.
================ Comment at: clang-tidy/google/FunctionNamingCheck.cpp:35 + // non-standard capitalized character sequences including acronyms, + // initialisms, and prefixes of symbols (e.g., UIColorFromNSString). For this + // reason, the regex only verifies that the function name after the prefix ---------------- benhamilton wrote: > Any reason why this is different from the implementation in the property name > checker? Either we should allow both of: > > ``` > void ARBiTraRilyNameDFuncTioN(); > // ... > @property (...) id arBItrArIlyNameD; > ``` > > or we should require that acronyms in the middle of the name be > registered/known acronyms for both properties and functions. > > I believe this diff allows arbitrary capitalization for functions, but we > disallowed that for property names, so I think we should be consistent. (And, just to be clear, I don't feel strongly which direction we go — it's certainly less work to allow arbitrarily-named functions and properties than to maintain the acronym list.) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
