JDevlieghere added inline comments.

================
Comment at: Sema/SemaExpr.cpp:5338
             Context.DependentTy, VK_RValue, RParenLoc);
       } else {
 
----------------
jkorous wrote:
> JDevlieghere wrote:
> > While you're at it you might as well remove the else branch here.
> Sorry, I am not following. Do you mean just refactoring?
> 
> ```
> if a
>   foo
> else
>   bar
> 
> ```
> ->
> ```
> if a
>   foo
> 
> bar
> ```
> 
> Or do you really mean removing the else branch? I don't see how that would be 
> NFC.
Yup, that's what I meant. since we have a return anyway. 


Repository:
  rC Clang

https://reviews.llvm.org/D51488



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to