ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall, kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, mgorny.
Given that the indexer binary is put directly into ./bin directory when built, 'clangd-' prefix seems to provide better context to the reader than 'global-'. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp clangd/symbol-builder/CMakeLists.txt clangd/symbol-builder/SymbolBuilderMain.cpp test/CMakeLists.txt Index: test/CMakeLists.txt =================================================================== --- test/CMakeLists.txt +++ test/CMakeLists.txt @@ -55,7 +55,7 @@ # These individual tools have no tests, add them here to make them compile # together with check-clang-tools, so that we won't break them in the future. - global-symbol-builder + clangd-symbol-builder # Unit tests ExtraToolsUnitTests Index: clangd/symbol-builder/SymbolBuilderMain.cpp =================================================================== --- clangd/symbol-builder/SymbolBuilderMain.cpp +++ clangd/symbol-builder/SymbolBuilderMain.cpp @@ -225,11 +225,11 @@ Example usage for building index for the whole project using CMake compile commands: - $ global-symbol-builder --executor=all-TUs compile_commands.json > index.yaml + $ clangd-symbol-builder --executor=all-TUs compile_commands.json > index.yaml Example usage for file sequence index without flags: - $ global-symbol-builder File1.cpp File2.cpp ... FileN.cpp > index.yaml + $ clangd-symbol-builder File1.cpp File2.cpp ... FileN.cpp > index.yaml Note: only symbols from header files will be collected. )"; Index: clangd/symbol-builder/CMakeLists.txt =================================================================== --- clangd/symbol-builder/CMakeLists.txt +++ clangd/symbol-builder/CMakeLists.txt @@ -4,11 +4,11 @@ Support ) -add_clang_executable(global-symbol-builder - GlobalSymbolBuilderMain.cpp +add_clang_executable(clangd-symbol-builder + SymbolBuilderMain.cpp ) -target_link_libraries(global-symbol-builder +target_link_libraries(clangd-symbol-builder PRIVATE clangAST clangIndex Index: clangd/CMakeLists.txt =================================================================== --- clangd/CMakeLists.txt +++ clangd/CMakeLists.txt @@ -73,4 +73,4 @@ add_subdirectory(fuzzer) endif() add_subdirectory(tool) -add_subdirectory(global-symbol-builder) +add_subdirectory(symbol-builder)
Index: test/CMakeLists.txt =================================================================== --- test/CMakeLists.txt +++ test/CMakeLists.txt @@ -55,7 +55,7 @@ # These individual tools have no tests, add them here to make them compile # together with check-clang-tools, so that we won't break them in the future. - global-symbol-builder + clangd-symbol-builder # Unit tests ExtraToolsUnitTests Index: clangd/symbol-builder/SymbolBuilderMain.cpp =================================================================== --- clangd/symbol-builder/SymbolBuilderMain.cpp +++ clangd/symbol-builder/SymbolBuilderMain.cpp @@ -225,11 +225,11 @@ Example usage for building index for the whole project using CMake compile commands: - $ global-symbol-builder --executor=all-TUs compile_commands.json > index.yaml + $ clangd-symbol-builder --executor=all-TUs compile_commands.json > index.yaml Example usage for file sequence index without flags: - $ global-symbol-builder File1.cpp File2.cpp ... FileN.cpp > index.yaml + $ clangd-symbol-builder File1.cpp File2.cpp ... FileN.cpp > index.yaml Note: only symbols from header files will be collected. )"; Index: clangd/symbol-builder/CMakeLists.txt =================================================================== --- clangd/symbol-builder/CMakeLists.txt +++ clangd/symbol-builder/CMakeLists.txt @@ -4,11 +4,11 @@ Support ) -add_clang_executable(global-symbol-builder - GlobalSymbolBuilderMain.cpp +add_clang_executable(clangd-symbol-builder + SymbolBuilderMain.cpp ) -target_link_libraries(global-symbol-builder +target_link_libraries(clangd-symbol-builder PRIVATE clangAST clangIndex Index: clangd/CMakeLists.txt =================================================================== --- clangd/CMakeLists.txt +++ clangd/CMakeLists.txt @@ -73,4 +73,4 @@ add_subdirectory(fuzzer) endif() add_subdirectory(tool) -add_subdirectory(global-symbol-builder) +add_subdirectory(symbol-builder)
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits