kbobyrev updated this revision to Diff 165236. kbobyrev marked an inline comment as done. kbobyrev added a comment.
Move assertion back to ctors. https://reviews.llvm.org/D52016 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index: clang-tools-extra/clangd/index/dex/Iterator.cpp =================================================================== --- clang-tools-extra/clangd/index/dex/Iterator.cpp +++ clang-tools-extra/clangd/index/dex/Iterator.cpp @@ -198,7 +198,7 @@ public: explicit OrIterator(std::vector<std::unique_ptr<Iterator>> AllChildren) : Children(std::move(AllChildren)) { - assert(Children.size() > 0 && "OR iterator must have at least one child."); + assert(!Children.empty() && "OR iterator should have at least one child."); } /// Returns true if all children are exhausted. @@ -405,12 +405,16 @@ std::unique_ptr<Iterator> createAnd(std::vector<std::unique_ptr<Iterator>> Children) { - return llvm::make_unique<AndIterator>(move(Children)); + // If there is exactly one child, pull it one level up: AND(Child) -> Child. + return Children.size() == 1 ? std::move(Children.front()) + : llvm::make_unique<AndIterator>(move(Children)); } std::unique_ptr<Iterator> createOr(std::vector<std::unique_ptr<Iterator>> Children) { - return llvm::make_unique<OrIterator>(move(Children)); + // If there is exactly one child, pull it one level up: OR(Child) -> Child. + return Children.size() == 1 ? std::move(Children.front()) + : llvm::make_unique<OrIterator>(move(Children)); } std::unique_ptr<Iterator> createTrue(DocID Size) {
Index: clang-tools-extra/clangd/index/dex/Iterator.cpp =================================================================== --- clang-tools-extra/clangd/index/dex/Iterator.cpp +++ clang-tools-extra/clangd/index/dex/Iterator.cpp @@ -198,7 +198,7 @@ public: explicit OrIterator(std::vector<std::unique_ptr<Iterator>> AllChildren) : Children(std::move(AllChildren)) { - assert(Children.size() > 0 && "OR iterator must have at least one child."); + assert(!Children.empty() && "OR iterator should have at least one child."); } /// Returns true if all children are exhausted. @@ -405,12 +405,16 @@ std::unique_ptr<Iterator> createAnd(std::vector<std::unique_ptr<Iterator>> Children) { - return llvm::make_unique<AndIterator>(move(Children)); + // If there is exactly one child, pull it one level up: AND(Child) -> Child. + return Children.size() == 1 ? std::move(Children.front()) + : llvm::make_unique<AndIterator>(move(Children)); } std::unique_ptr<Iterator> createOr(std::vector<std::unique_ptr<Iterator>> Children) { - return llvm::make_unique<OrIterator>(move(Children)); + // If there is exactly one child, pull it one level up: OR(Child) -> Child. + return Children.size() == 1 ? std::move(Children.front()) + : llvm::make_unique<OrIterator>(move(Children)); } std::unique_ptr<Iterator> createTrue(DocID Size) {
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits