lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land.
Thank you for working on this! In https://reviews.llvm.org/D52120#1235480, @lebedev.ri wrote: > In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote: > > > @lebedev.ri could you help test whether this fully resolves PR38891? Thanks! > > > That is what i'm trying to do here :) > Still waiting for the build to finish... Ok, got the results. Without that change, my check fires ~1k times. With this change it only fires 572 times. So this clearly //changes// things. The entirety of the new build log: F7199224: buildlog.txt <https://reviews.llvm.org/F7199224> I see no mentions of `emplace_back`/`push_back`. Though some of that is still false-positives (pointers, va_arg, callback lambdas passed as templated function param), but i'll file further bugs i guess. As far i'm concerned, this is good. But please wait for the actual code review. Once again, thank you for working on this! Repository: rC Clang https://reviews.llvm.org/D52120 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits