Oh, I see. Thank you very much for fixing it! I had concerns about platform dependence, but I’ve seen seen some tests in libcxx which use `if […]` so I thought it should be alright (because there was no REQUIRES there). I can see now, that it is a Darwin test, my bad.
Again, thank you very much for helping and apologies for inconvenience. Kind regards, Kirill > On 14 Sep 2018, at 22:53, Reid Kleckner <r...@google.com> wrote: > > That construct does not work on Windows, where we don't use bash. We use the > lit internal shell, which doesn't support 'if [ ...]'. I marked it REQUIRES: > shell in r342282. > > On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Author: omtcyfz > Date: Wed Sep 12 02:27:55 2018 > New Revision: 342036 > > URL: http://llvm.org/viewvc/llvm-project?rev=342036&view=rev > <http://llvm.org/viewvc/llvm-project?rev=342036&view=rev> > Log: > Fix buildbots after r342027 > > Modified: > clang-tools-extra/trunk/test/clangd/index-tools.test > > Modified: clang-tools-extra/trunk/test/clangd/index-tools.test > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/index-tools.test?rev=342036&r1=342035&r2=342036&view=diff > > <http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/index-tools.test?rev=342036&r1=342035&r2=342036&view=diff> > ============================================================================== > --- clang-tools-extra/trunk/test/clangd/index-tools.test (original) > +++ clang-tools-extra/trunk/test/clangd/index-tools.test Wed Sep 12 02:27:55 > 2018 > @@ -1,2 +1,3 @@ > # RUN: global-symbol-builder %p/Inputs/BenchmarkSource.cpp -- -I%p/Inputs > > %t.index > -# RUN: %clangd-benchmark-dir/IndexBenchmark %t.index %p/Inputs/requests.log > --benchmark_min_time=0.01 > +# FIXME: By default, benchmarks are excluded from the list of default > targets hence not built. Find a way to depend on benchmarks to run the next > command. > +# RUN: if [ -f %clangd-benchmark-dir/IndexBenchmark ]; then > %clangd-benchmark-dir/IndexBenchmark %t.index %p/Inputs/requests.log > --benchmark_min_time=0.01 ; fi > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
