rsmith added inline comments.

================
Comment at: clang/lib/Frontend/DependencyFile.cpp:340
+    return;
+  StringRef Filename = File->getName();
+  if (!FileMatchesDepCriteria(Filename.data(), FileType))
----------------
Should we really be using the (arbitrary) name of the file from the `FileEntry` 
rather than the name as written? It looks like the corresponding code for 
`InclusionDirective` uses the name as written instead.


https://reviews.llvm.org/D30882



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to