ormris added a comment. In https://reviews.llvm.org/D52058#1237868, @JDevlieghere wrote:
> Generally this looks good, but I'd like for the other to have a look first > (at this and the other patch) before accepting. Sounds good. Thanks for your comments! ================ Comment at: lib/CodeGen/CGDebugInfo.cpp:1783 + if (auto *TS = dyn_cast<VarTemplateSpecializationDecl>(VL)) { + if (TS->getSpecializedTemplateOrPartial() + .is<VarTemplatePartialSpecializationDecl *>()) { ---------------- JDevlieghere wrote: > JDevlieghere wrote: > > Might be nice to add a comment here saying what you're doing in this block > > and below. Looks like the top one is for partial specialization and the > > bottom one for the general case? > I also suggest to extract `TS->getSpecializedTemplateOrPartial()` into a > variable to make this a little less dense. Hmm... Yeah. I'll take a look at clarifying this section. Repository: rC Clang https://reviews.llvm.org/D52058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits