Hi Stephen, Your change is causing a test failure on the PS4 linux bot, can you please take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/36712/steps/test/logs/stdio FAIL: Clang :: Driver/clang_f_opts.c (8141 of 44013) ******************** TEST 'Clang :: Driver/clang_f_opts.c' FAILED ******************** ... Command Output (stderr): -- /home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/clang_f_opts.c:537:29: error: CHECK-NO-MIX-OMIT-FP-PG: expected string not found in input // CHECK-NO-MIX-OMIT-FP-PG: '-fomit-frame-pointer' not allowed with '-pg' ^ <stdin>:1:1: note: scanning from here clang version 8.0.0 (trunk 342502) ^ <stdin>:5:934: note: possible intended match here "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/bin/clang-8" "-cc1" "-triple" "x86_64-scei-ps4" "-S" "-disable-free" "-main-file-name" "clang_f_opts.c" "-mrelocation-model" "pic" "-pic-level" "2" "-mthread-model" "posix" "-masm-verbose" "-mconstructor-aliases" "-munwind-tables" "-target-cpu" "btver2" "-debugger-tuning=sce" "-mllvm" "-generate-arange-section" "-debug-forward-template-params" "-dwarf-explicit-import" "-coverage-notes-file" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver/clang_f_opts.gcno" "-resource-dir" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/lib/clang/8.0.0" "-fdebug-compilation-dir" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver" "-fstack-size-section" "-ferror-limit" "19" "-fmessage-length" "0" "-pg" "-stack-protector" "2" "-fdeclspec" "-fobjc-runtime=gnustep" "-fdiagnostics-show-option" "-o" "clang_f_opts.s" "-x" "c" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/clang_f_opts.c" "-faddrsig" ^ Douglas Yung > -----Original Message----- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Stephen Hines via cfe-commits > Sent: Tuesday, September 18, 2018 11:35 > To: cfe-commits@lists.llvm.org > Subject: r342501 - Fix logic around determining use of frame pointer > with -pg. > > Author: srhines > Date: Tue Sep 18 11:34:33 2018 > New Revision: 342501 > > URL: http://llvm.org/viewvc/llvm-project?rev=342501&view=rev > Log: > Fix logic around determining use of frame pointer with -pg. > > Summary: > As part of r342165, I rewrote the logic to check whether > -fno-omit-frame-pointer was passed after a -fomit-frame-pointer > argument. This CL switches that logic to use the consolidated > shouldUseFramePointer() function. This fixes a potential issue where - > pg > gets used with -fomit-frame-pointer on a platform that must always > retain > frame pointers. > > Reviewers: dblaikie > > Reviewed By: dblaikie > > Subscribers: cfe-commits > > Differential Revision: https://reviews.llvm.org/D52191 > > Modified: > cfe/trunk/lib/Driver/ToolChains/Clang.cpp > > Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp > URL: http://llvm.org/viewvc/llvm- > project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=342501&r1=342500& > r2=342501&view=diff > ======================================================================= > ======= > --- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original) > +++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Tue Sep 18 11:34:33 2018 > @@ -4956,8 +4956,7 @@ void Clang::ConstructJob(Compilation &C, > } > > if (Arg *A = Args.getLastArg(options::OPT_pg)) > - if (Args.hasFlag(options::OPT_fomit_frame_pointer, > - options::OPT_fno_omit_frame_pointer, > /*default=*/false)) > + if (shouldUseFramePointer(Args, Triple)) > D.Diag(diag::err_drv_argument_not_allowed_with) << "-fomit- > frame-pointer" > << A- > >getAsString(Args); > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
