Anastasia added inline comments.
================ Comment at: lib/Headers/opencl-c.h:26 +#if __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#ifndef cl_intel_planar_yuv +#define cl_intel_planar_yuv ---------------- Anastasia wrote: > @yaxunl, do you think we need to add some kind of architecture guard for such > things? Like it should only be added if the architecture supports the > extension? But I guess `-cl-ext=+cl_intel_planar_yuv` trick might not work > here because it's not a Clang known extension? > > So may be the right solution here is to introduce a target specific header? > For now it can be explicitly included but we could think of a target hook to > preload a target specific header... @sidorovd, I am wondering if we could instead extend '-cl-ext=+cl_intel_planar_yuv' to work with non-builtin extensions? Would that be an acceptable solution for vendor extensions to be added to the common header? https://reviews.llvm.org/D51402 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
