JonasToth added inline comments.

================
Comment at: clang-tidy/utils/TypeTraits.cpp:47
+
+  // Do not consider "expensive to copy" types not greater than a pointer
+  if (Context.getTypeSize(Type) <= Context.getTypeSize(Context.VoidPtrTy))
----------------
Please make that comment a sentence, and maybe don't use `not` twice.

What do you think about making this parameter configurable and/or set it in 
relation to the size of a cache-line.
This is of course target dependent, but given the CPU effects more accurate.


https://reviews.llvm.org/D52315



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to