thakis added inline comments.

================
Comment at: include/clang/Driver/CLCompatOptions.td:121
+def : CLFlag<"Ob0">, Alias<_SLASH_O>, AliasArgs<["b0"]>, HelpText<"Disable 
function inlining">;
+def : CLFlag<"Ob1">, Alias<_SLASH_O>, AliasArgs<["b1"]>, HelpText<"Only inline 
functions which are (explicitly or implicitly) marked inline">;
+def : CLFlag<"Ob2">, Alias<_SLASH_O>, AliasArgs<["b2"]>, HelpText<"Inline 
functions as deemed beneficial by the compiler">;
----------------
Also, can we try to keep these at 80 columns?

The other flags in this file put HelpText before Alias and AliasArg (see my 
diff), but your order is fine. The 80 columns help trying to keep the help text 
concise, so it encourages better UI in this case :-)


https://reviews.llvm.org/D52266



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to