aaron.ballman added inline comments.

================
Comment at: include/clang/AST/DeclBase.h:563
@@ +562,3 @@
+  /// \brief Return true if this declaration is a definition of alias or ifunc.
+  bool hasDefiningAttr() const;
+
----------------
rjmccall wrote:
> aaron.ballman wrote:
> > I think this function and getDefiningAttr() can be defined in the header 
> > instead of split into the source file. The implementations are short enough 
> > that inlining may be nice to allow.
> getDefiningAttr can't be defined in the header without including Attr.h.  We 
> could define hasDefiningAttr in terms of getDefiningAttr, but it wouldn't 
> allow much interesting optimization.
Good point; definitely not worth it.


http://reviews.llvm.org/D15524



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to