devnexen added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275
+ os << "sizeof(" << DstName << ")";
+ else
+ os << "sizeof(<destination buffer>)";
----------------
MaskRay wrote:
> Why can't this `else if` case be folded into the `strlcpy` case? There are
> lots of duplication.
>
> `strlcpy` does not check `DstName.empty()` but this one does. Is there any
> cases I am missing?
strlcpy does but agreed with your first statement, this handling case for both
are more different than my initial plan defined them.
https://reviews.llvm.org/D49722
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
