sammccall added a comment. Thanks for doing this! Sorry for the dumb questions, I don't get cmake.
================ Comment at: test/CMakeLists.txt:36 set(CLANG_TOOLS_TEST_DEPS # For the clang-apply-replacements test that uses clang-rename. ---------------- can we add all of clangd to this list with a loop, instead of duplicating? ================ Comment at: test/CMakeLists.txt:76 -set(llvm_utils - FileCheck count not - ) - -foreach(t ${llvm_utils}) - if(TARGET ${t}) - list(APPEND CLANG_TOOLS_TEST_DEPS ${t}) - endif() -endforeach() - +macro(add_llvm_utils_deps deps) + set(llvm_utils ---------------- Conversely, I'd consider just expanding these out into each of the dep lists rather than keeping two levels of indirection here. ================ Comment at: test/CMakeLists.txt:107 +add_lit_testsuite(check-clangd "Running the Clangd regression tests" + ${CMAKE_CURRENT_BINARY_DIR}/Unit/clangd;${CMAKE_CURRENT_BINARY_DIR}/clangd + DEPENDS ${CLANGD_TEST_DEPS} ---------------- Is /Unit/ really right? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits