lebedev.ri added inline comments.
================ Comment at: include/clang/Basic/DiagnosticGroups.td:167-168 + CXX11ExtraSemi, + ExtraSemiStmt, + EmptyInitStatement]>; ---------------- rsmith wrote: > I would prefer to keep `-Wextra-semi` and `-Wextra-semi-stmt` separate. > `-Wextra-semi` is for those cases that are ill-formed in C++98, whereas your > new warning is only about code style / typo detection. Hmm, does that mean ExtraSemiStmt[+EmptyInitStatement] should be in `-Wextra`? ================ Comment at: lib/Parse/ParseStmt.cpp:1600 + llvm::Optional<SourceLocation> EmptyInitStmtSemiLoc; + ---------------- rsmith wrote: > You can just use a `SourceLocation` here; it already has an 'invalid' state. Aha. Repository: rC Clang https://reviews.llvm.org/D52695 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
