[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang-tidy/utils/Matchers.cpp:20
+matchesAnyListedName(const std::vector<std::string> &NameList) {
+  SmallString<256> NameRegEx;
+  llvm::raw_svector_ostream NameOut(NameRegEx);
----------------
baloghadamsoftware wrote:
> lebedev.ri wrote:
> > ```
> > if(NameList.empty())
> >   return false;
> > ```
> `false`? But this functions returns `Matcher<NamedDecl>`.
Hm, then `unless(anything())`, or `unless(anything()).matches(Node, Finder, 
Builder)`.


https://reviews.llvm.org/D52727



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits