sammccall marked an inline comment as done. sammccall added inline comments.
================ Comment at: clangd/indexer/IndexerMain.cpp:58 SymbolCollector::Options Opts; - Opts.FallbackDir = AssumedHeaderDir; return createStaticIndexingAction( ---------------- hokein wrote: > If we remove the `assume-header-dir`, we probably remove `FallbackDir` too? I > can't remember why we added this option, there is no usage internally either. It's used in our internal `mr_indexer` ================ Comment at: clangd/indexer/IndexerMain.cpp:84 - $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml + $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index ---------------- sammccall wrote: > hokein wrote: > > ilya-biryukov wrote: > > > Maybe we should suggest a default extensions here? E.g. `index.riff`? > > +1 > I considered this but am not sure it's useful: > - means an unneccesary change to workflows if we change the format (happened > once!) > - riff is associated with audio, and I'd expect OSes that care about > extensions to draw the wrong conclusion :-) Settled on `clangd.dex` which is at least easy to understand and only kind of misleading. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52872 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits