xbolva00 added inline comments.
================ Comment at: lib/Sema/SemaType.cpp:2232 + + if (isa<BinaryOperator>(ArraySize)) + ArraySize->EvaluateForOverflow(Context); ---------------- xbolva00 wrote: > Rakete1111 wrote: > > What's up with this statement? Why is it needed? This won't handle > > overflows for unary expression for example. > Ok, I should use Sema::CheckForIntOverflow > > But anyway, CheckForIntOverflow does not care about UnaryOperator either > currently :) Anyway, the negative array size is handled a few lines above. https://reviews.llvm.org/D52750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
