rsmith added a comment. In https://reviews.llvm.org/D52973#1259992, @mwasplund wrote:
> In https://reviews.llvm.org/D52973#1259909, @rsmith wrote: > > > Generally this looks good, but it needs an accompanying test. > > > I was looking into that and trying to read up on the documentation for adding > tests. I think I understand the crazy comment RUN test invocation, but got > lost in the directory structure. Is there documentation on naming and placing > regression tests? At first glance it seems arbitrary to me if the file is > something like p6.cpp (which don't appear to be sequential) or > my-test-name.cpp. The tests under test/CXX are organized by section and paragraph of the C++ standard (we also have subdirectories for TSes, which are organized likewise, and for DRs, which are organized by number). The tests outside test/CXX are organized by the relevant part or feature of the compiler. Since this is a modules-specific failure but it's not related to a specific part of the Modules TS (in fact, it's an interaction between an MSVC-compatibility hack and our Modules TS implementation), the best home for it is probably a test in test/Modules, which you can name after the behavior you're testing (eg, ms-compat-typeinfo.cpp or similar). All inputs to the test other than the main test file should go in test/Modules/Inputs, in a subdirectory named after the stem of the test file (eg, test/Modules/Inputs/ms-compat-typeinfo). Repository: rC Clang https://reviews.llvm.org/D52973 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
