sammccall added inline comments.
================ Comment at: clangd/ClangdLSPServer.h:117 + llvm::Optional<Path> CompileCommandsDir, + std::function<void(llvm::StringRef, + const tooling::CompilationDatabase &)>); ---------------- ioeric wrote: > please document what the callback is for and how often it's called. Documented at the callsite and in GlobalCompilationDatabase.h. This class here is really just plumbing (it shouldn't be in the header at all) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53032 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
