juliehockett marked 3 inline comments as done.
juliehockett added inline comments.


================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:203
+llvm::Expected<std::unique_ptr<ToolExecutor>>
+createClangDocExecutor(int &argc, const char **argv,
+                       llvm::cl::OptionCategory &Category) {
----------------
ioeric wrote:
> This is exposing too much implementation details.I landed a patch to expose 
> the `ExecutorName` option from the library (rL344335) so you could simply do 
> `ExecutorName.setInitialValue("all-TUs")` before calling 
> `createExecutorFromCommandLineArgs()`.
Perfect. Thanks!


https://reviews.llvm.org/D53170



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to