leonardchan accepted this revision.
leonardchan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp:39-40
+    return writeInfo(*static_cast<FunctionInfo *>(I));
+  default:
+    return "";
+  }
----------------
Nit: The `dispatchInfoForWrite` function returns true on default and writeInfo 
would catch that assert. I assume just returning empty string is intended on 
this case?


https://reviews.llvm.org/D53381



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to