jrtc27 added inline comments.
================ Comment at: lib/Driver/ToolChains/Gnu.cpp:1912 - static const char *const RISCV32LibDirs[] = {"/lib", "/lib32"}; + static const char *const RISCVLibDirs[] = {"/lib", "/lib32"}; static const char *const RISCVTriples[] = {"riscv32-unknown-linux-gnu", ---------------- Surely this should remain as `RISCV32LibDirs`? Also, should we reverse the order (put `"/lib32"` first) to match every single other architecture? ================ Comment at: lib/Driver/ToolChains/Gnu.cpp:1913 + static const char *const RISCVLibDirs[] = {"/lib", "/lib32"}; static const char *const RISCVTriples[] = {"riscv32-unknown-linux-gnu", "riscv32-unknown-elf"}; ---------------- `RISCV32Triples`? Also, why do we have no `"riscv32-linux-gnu"` entry like the other architectures? ================ Comment at: lib/Driver/ToolChains/Gnu.cpp:1915 "riscv32-unknown-elf"}; + static const char *const RISCV64LibDirs[] = {"/lib", "/lib64"}; + static const char *const RISCV64Triples[] = {"riscv64-unknown-linux-gnu", ---------------- Order as for 32. ================ Comment at: lib/Driver/ToolChains/Gnu.cpp:1916 + static const char *const RISCV64LibDirs[] = {"/lib", "/lib64"}; + static const char *const RISCV64Triples[] = {"riscv64-unknown-linux-gnu", + "riscv64-unknown-elf"}; ---------------- `riscv64-linux-gnu`? Repository: rC Clang https://reviews.llvm.org/D53392 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits