Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land.
================ Comment at: test/Headers/opencl-pragma-extension-begin.cl:1 +// RUN: rm -rf %t +// RUN: mkdir -p %t ---------------- I think the tests in this folder are for standard includes only but you are testing custom include file here. Could this be integrated into test/SemaOpenCL/extension-begin.cl? Or if else you could just move to that folder (it might be better to append module to the name in that case). ================ Comment at: test/Headers/opencl-pragma-extension-begin.cl:11 + +void __kernel test(__global int *data) { + *data = 10; ---------------- May be it makes sense to test the added extension? https://reviews.llvm.org/D53200 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits