NoQ added inline comments.
================
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:515
+ continue;
+ const auto *FirstAccess = Accesses[0].getNodeAs<MemberExpr>("access");
+
----------------
I feel that it's a good practice to `assert(FirstAccess)` here (same for
`FirstGuard` and generally after every `getNodeAs`). The assertion will hold
because "access" is always bound to on every possible match and is always a
member-expression, and it'd be great to check that after the matcher is changed.
https://reviews.llvm.org/D51866
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
