On Fri, Oct 19, 2018 at 3:56 PM Adrian Prantl via Phabricator via llvm-commits <llvm-comm...@lists.llvm.org> wrote:
> aprantl added a comment. > > I have a vague recollection that this column info hack was added to > disambiguate two types defined on the same line (which is something that > happened more often than one would think because of macro expansion). Did > you do the git archeology to ensure that the original reason for doing it > this way has been resolved? FWIW, I'm fine with doing this change for the > Darwin platforms because column info is turned on by default, so this > shouldn't affect us. > It was (I think) duplicate calls (rather than types) - so that inlining (which previously didn't produce a unique'd inlinedAt location (because we didn't have the "unique" metadata feature)) didn't collapse the instructions from the two inlined calls into one. > > > Repository: > rC Clang > > https://reviews.llvm.org/D38061 > > > > _______________________________________________ > llvm-commits mailing list > llvm-comm...@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits