JonasToth added inline comments.
================ Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:58 + const QualType Rhs) { + assert(Lhs->isRealType()); // Either integer or floating point. + assert(Rhs->isFloatingType()); // Floating point only. ---------------- Couldn't be the conversion from an `int` to an `enum` be considered narrowing as well? (Not sure about the word of the standard) I think it makes sense to change the `assert` to `return false` ================ Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:82 + << RhsType << LhsType; } } ---------------- could you please add a final `llvm_unreachable()` to ensure that all possibilites are properly handled? If that would not fit I would prefer ealry returns instead to show "the end" for each logical path Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits