aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with some fixes to the wording.
================
Comment at: clang-query/Query.cpp:57
+ " detailed-ast "
+ "Detailed AST output for bound nodes\n"
" dump "
----------------
Add full stop at the end of the sentence.
================
Comment at: clang-query/Query.cpp:59
" dump "
- "Detailed AST output for bound nodes\n\n";
+ "Detailed AST output for bound nodes (alias of deatiled-ast)\n\n";
return true;
----------------
Typo: deatiled -> detailed
================
Comment at: clang-query/QueryParser.cpp:119
+ return new InvalidQuery(
+ "expected 'diag', 'print', 'detailed-ast' or 'dump', got '" + ValStr +
+ "'");
----------------
This is reasonable, but as you add new output modes, hopefully this list won't
need to be duplicated from above.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
