rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Looks good.

We should provide some reserved-name way of naming clang attributes too, but 
I'm not sure what would be best (`__clang__` is a macro name). Maybe `_Clang`? 
(And maybe we should detect an integer literal `1` as a scope specifier and 
check whether it was written as a macro `__clang__`, and provide a custom error 
suggesting using whatever other scope specifier we prefer.)


https://reviews.llvm.org/D53591



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D53591: S... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D535... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D535... Aaron Ballman via Phabricator via cfe-commits

Reply via email to