JonasToth added inline comments.
================ Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:84 + + // Check for floats without fractional components + if (const auto *LitFloat = ---------------- alexfh wrote: > JonasToth wrote: > > missing full stop > Clang-tidy (and clang) diagnostics don't end with a period. This one doesn't > need to be special in this regard. Same below. I believe that was related to a comment to make it a full sentence with grammar and so on, AFAIK these are supposed to be correct. The diagnostic message itself not, I did not intend to include it. https://reviews.llvm.org/D53339 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
