Szelethus added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:82
-static void EmitRanges(raw_ostream &o,
- const ArrayRef<SourceRange> Ranges,
- const FIDMap& FM,
- const Preprocessor &PP,
- unsigned indent) {
+ void ReportDiag(raw_ostream &o, const PathDiagnosticPiece& P) {
+ ReportPiece(o, P, /*indent*/ 4, /*depth*/ 0, /*includeControlFlow*/ true);
----------------
NoQ wrote:
> Szelethus wrote:
> > xazax.hun wrote:
> > > The `raw_ostream` seems to be a common argument. MAybe it would be worth
> > > to make that a member too?
> > I did that, and then later changed it back for debugging purposes, if
> > anyone needs to print note pieces to errs or something.
> I guess both problems could be solved by doing a private method `raw_ostream`
> while also wrapping it into a public method with a default `raw_ostream`.
I think that would add unnecessary complication for very little value. I'd
rather commit as is.
https://reviews.llvm.org/D53810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
