djasper added a comment.

I think this roughly looks fine. Krasimir, any thoughts?



================
Comment at: unittests/Format/FormatTest.cpp:11854
+  // case above.
+  {
+    auto Style = getGoogleStyle();
----------------
No need to use a scope here. Feel free to redefine Style.

If in fact you feel like that is getting out of hand, maybe extract a separate 
TEST_F() for this.


================
Comment at: unittests/Format/FormatTest.cpp:11865
+  }
+  {
+    verifyFormat("SomeFunction(\n"
----------------
No need for this scope.


Repository:
  rC Clang

https://reviews.llvm.org/D52676



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to