aheejin added inline comments.
================ Comment at: lib/CodeGen/CGBuiltin.cpp:12528 + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4: + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: { Value *Src = EmitScalarExpr(E->getArg(0)); ---------------- tlively wrote: > aheejin wrote: > > But unlike others, isn't the input type different from the output type for > > this builtin? It seems other non-SIMD `saturate_s` intrinsics follow the > > same convention, `trunc_saturate_s_output_input`. > Ok, I can put the return type back in. My rationale for removing it was that > for the SIMD truncations, the return type is uniquely determined by the input > type, so specifying both in the name is redundant. I see, but I still think it's easier to readers if they specify return types, in that they don't have to look up SIMD specs when using builtins. Repository: rC Clang https://reviews.llvm.org/D53724 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits