kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed.
In https://reviews.llvm.org/D52998#1284146, @eandrews wrote: > @kbobyrev I apologize if I was unclear in the comments. I was asking if the > changes proposed in the comments are alright with you since they would > involve modifying `benchmark/CMakelists.txt` (instead of > `llvm/CMakeLists.txt` as discussed in mailing list). As Zachary mentioned in > comments, `_HAS_EXCEPTIONS` should be set to 0 only when exceptions are > disabled. Since exception handling for benchmarks is handled in > `benchmark/CMakeLists.txt`, I think it makes most sense to add the definition > there. I have now uploaded the proposed change for review. > > I am still working with my company to figure out the corporate CLA Google's > benchmark project requires for patch submissions. I can submit the patch > upstream once that is done. If you would prefer to submit the patch upstream > yourself, please feel free to do so. > > Sorry again for the confusion! Ah, my bad, I didn't notice it's the `utils/benchmark/CMakeLists.txt` :( Apologies. Upstreaming it first might be better, especially since the change seems to be trivial. Is this line addition the only change proposed for the benchmark library? If so, I could submit a PR and probably get it accepted within the next few days. Then this patch would simply add commit hash and small notice to `utils/benchmark/README.LLVM` and that would be it. Do you want me to submit the patch to the benchmark library? It seems that it would help to speedup the process. https://reviews.llvm.org/D52998 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
