NoQ added inline comments.
================ Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149 +/// If you'd like to add a new -cc1 flag, add it to +/// include/clang/Driver/CC1Options.td, add a new field to store the value of +/// that flag in this class, and initialize it in +/// lib/Frontend/CompilerInvocation.cpp. ---------------- Nono, don't add more -cc1 flags :) ================ Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:172 + .getAsInteger(10, *V); + assert(!HasFailed && "analyzer-config option should be numeric"); + (void)HasFailed; ---------------- I guess @xazax.hun's comment also applies to this assert. https://reviews.llvm.org/D53483 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
