ioeric added inline comments.
================ Comment at: lib/Tooling/AllTUsExecution.cpp:58 + "filter", + llvm::cl::desc("Only process files that match this filter"), + llvm::cl::init(".*")); ---------------- Please also mention that this only applies to all-TUs. ================ Comment at: lib/Tooling/AllTUsExecution.cpp:120 for (std::string File : Files) { + if (Filter.getNumOccurrences() != 0 && !RegexFilter.match(File)) + continue; ---------------- > `Filter.getNumOccurrences() != 0 ` Would this work if `Filter` is set grammatically? Although it's not exposed now, it might make more sense to check `Filter != ".*"`. Repository: rC Clang https://reviews.llvm.org/D54092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits