Szelethus added a comment.

Please reupload with full context.



================
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2369
   ProgramStateRef state = C.getState();
-  RegionStateTy RS = state->get<RegionState>();
+  RegionStateTy OldRS = state->get<RegionState>();
   RegionStateTy::Factory &F = state->get_context<RegionState>();
----------------
We are acquiring an object of type `ImmutableMap`, modify it, and put it back 
into `state`? Can't we just modify it through `ProgramState`'s interface 
directly?


Repository:
  rC Clang

https://reviews.llvm.org/D54013



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to