juliehockett added a comment.

In https://reviews.llvm.org/D54168#1289128, @JonasToth wrote:

> I think this check is ok in the current form, but does it really need to be 
> in upstream clang-tidy? You said its for migration only, so it is not 
> valuable for you for a long time either?


So yes, this check is for a migration, and we would delete it once regressions 
weren't possible. We would like the suite to be in upstream, however, because 
we use the ToT llvm/clang/tools/etc, and don't want to have to fork just to use 
clang-tidy for this sort of thing. Since clang-tidy doesn't provide any way to 
have external checks to the tool itself, upstreaming is the most ideal option.

Orthogonal to our particular build setup, it'd also be nice to have an example 
of this sort of migration done by clang-tidy in-tree. There has been a lot of 
discussion recently about doing migrations with clang-tidy, but it's always 
describing an internal migration that uses a forked tree and a private suite of 
checks that can't be released.


https://reviews.llvm.org/D54168



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to