grimar added a comment. Looks like this behavior is what clang already have atm. Messages for the options that use `D.Diag` to report invalid values can be printed multiple times sometimes.
The example is below: clang main.cpp -fdwarf-fission=foo -o 1.o -mthread-model bar -fcf-runtime-abi=zed clang-8: error: invalid thread model 'bar' in '-mthread-model bar' for this target clang-8: error: unsupported argument 'foo' to option 'fdwarf-fission=' clang-8: error: invalid CoreFoundation Runtime ABI 'zed'; must be one of 'objc', 'standalone', 'swift', 'swift-5.0', 'swift-4.2', 'swift-4.1' clang main.cpp -fdwarf-fission=foo -o 1.o -mthread-model bar -fcf-runtime-abi=zed -save-temps clang-8: error: invalid thread model 'bar' in '-mthread-model bar' for this target clang-8: error: unsupported argument 'foo' to option 'fdwarf-fission=' clang-8: error: invalid CoreFoundation Runtime ABI 'zed'; must be one of 'objc', 'standalone', 'swift', 'swift-5.0', 'swift-4.2', 'swift-4.1' clang-8: error: invalid thread model 'bar' in '-mthread-model bar' for this target clang-8: error: unsupported argument 'foo' to option 'fdwarf-fission=' clang-8: error: invalid CoreFoundation Runtime ABI 'zed'; must be one of 'objc', 'standalone', 'swift', 'swift-5.0', 'swift-4.2', 'swift-4.1' clang-8: error: invalid thread model 'bar' in '-mthread-model bar' for this target clang-8: error: unsupported argument 'foo' to option 'fdwarf-fission=' clang-8: error: invalid CoreFoundation Runtime ABI 'zed'; must be one of 'objc', 'standalone', 'swift', 'swift-5.0', 'swift-4.2', 'swift-4.1' clang-8: error: unsupported argument 'foo' to option 'fdwarf-fission=' So it seems to me this patch just follows the behavior and nothing should be fixed at this point right now? https://reviews.llvm.org/D52296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
