sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

This is hacky, but solves an important problem. If you know of a good reviewer 
for this, you may want a second opinion!



================
Comment at: include/clang/Lex/HeaderSearchOptions.h:111
 
+  /// Compiler install dir as detected by the Driver.
+  /// Only used to add include dirs for libc++ on Darwin. Please avoid relying
----------------
Could you add "typically contains bin/clang, lib/libclang_rt, and 
include/<builtins>"?


================
Comment at: lib/Frontend/CompilerInvocation.cpp:1776
   Opts.ResourceDir = Args.getLastArgValue(OPT_resource_dir);
+  Opts.InstallDir = Opts.ResourceDir;
 
----------------
(is this needed? I guess you fall back to this if you don't create the CI from 
the command line?)


Repository:
  rC Clang

https://reviews.llvm.org/D54310



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PAT... Ilya Biryukov via Phabricator via cfe-commits
    • ... Sam McCall via Phabricator via cfe-commits
    • ... Ilya Biryukov via Phabricator via cfe-commits
    • ... Ilya Biryukov via Phabricator via cfe-commits
    • ... Ilya Biryukov via Phabricator via cfe-commits
    • ... Phabricator via Phabricator via cfe-commits
    • ... Jonas Devlieghere via Phabricator via cfe-commits
      • ... Ilya Biryukov via cfe-commits
    • ... George Karpenkov via Phabricator via cfe-commits
      • ... Sam McCall via cfe-commits
        • ... Mailing List "llvm-commits" via Phabricator via cfe-commits
    • ... George Karpenkov via Phabricator via cfe-commits

Reply via email to